docs: Add REUSE.toml - #2328
Conversation
davidlattimore
left a comment
There was a problem hiding this comment.
Thanks for looking into this. Does this help with collating the licenses for all our dependencies and putting them in the release packages?
| ".vscode/**", | ||
| ".yamlfmt", | ||
| ".zed/**", | ||
| "BENCHMARKING.md", |
There was a problem hiding this comment.
So each time we add a new file, we have to add it here? That seems a bit onerous. Is there some tool that checks that? Why do we need per-file license information?
There was a problem hiding this comment.
Yeah, you are supposed to run reuse lint on CI or manually.
Why do we need per-file license information?
TBH, I have no clue. I don't know even if we need that, but REUSE seems to require all files to have license and copyright.
I thought it would, but I must have mistaken it with something else. REUSE apparently only helps with the code within the repo. Rust seems to have a homegrown tool for dependencies license handling. |
6e1d186 to
8c10eab
Compare
|
This is how failed REUSE check looks like: https://github.com/wild-linker/wild/actions/runs/31602029051/job/94131575815?pr=2328 Are we interested in going on with this? |
|
I'm unsure what I think about having to update it each time you add a file or directory to the root. I guess at least we don't have to for subdirectories and it would perhaps encourage us to put less files in the root - e.g. maybe we need a docs directory. It's also a bit annoying that we have to add a second copy of the license files. i.e. we have them in the I guess this is mostly of use for people wanting to use libwild as part of some other project. |
54e02c7 to
cf93749
Compare
Yeah, that's annoying but on the upside
TBH I'm a bit lost here. Previously I thought REUSE would take care of the deps, so this would cover cases for both packaging Wild and using as a library. But now I don't know if this change is even worth pushing for. |
cf93749 to
fdd112d
Compare
fdd112d to
f0e8704
Compare
8af666e to
89bf7f7
Compare
Their FAQ say that helping with licenses for dependencies is out of scope for REUSE.
Yeah, it does seem to be of pretty limited use - especially given that all of our code is under the same licenses. But the cost of maintaining it doesn't seem too onerous, so I don't object to merging this if you want to. |
cc #2234